Lindor's Mod for Sacred 2 EE development Thread

[Lindor 435]

I have completed but not finished the Standard Armor Set classification:

Spoiler

local classification = {
    Dryad = {
        AspectOne = {"Ivy"},
        AspectTwo = {"Leafs"},
        AspectThree = {"Crystal"},
        Generic = {"Special", "Generic"},
        Melee = {"Iron"},
        Ranged = {"Leather", "Cloth"},
        Spell = {"Magic"},
    },
    Seraphim = {
        AspectOne = {"Angel Dust"},
        AspectTwo = {"Ancient"},
        AspectThree = {"Mystique"},
        Generic = {"Special", "Generic", "Cloth"},
        Melee = {"Iron", "Sophia"},
        Ranged = {"Leather"},
        Spell = {"Magic", "Genesis"},
    },
    Shadow Warrior = {
        AspectOne = {"Enforcer"},
        AspectTwo = {"Exxo"},
        AspectThree = {"Crypt"},
        Generic = {"Special", "Cloth", "Generic"},
        Melee = {"Iron", "Leather"},
        Ranged = {"Redstorm", "Colossus"},
        Spell = {"Magic", "Scourge of Lordaeron", "Hellknight"},
    },
    High Elf = {
        AspectOne = {"Pearl"},
        AspectTwo = {"Diamond"},
        AspectThree = {"Raven"},
        Generic = {"Special", "Cloth", "Generic", "Lara's Glad Rags"},
        Melee = {"Iron", "Children of Asha"},
        Ranged = {"Range Array"},
        Spell = {"Magic", "Leather"},
    },
    Inquisitor = {
        AspectOne = {"Blood Poison"},
        AspectTwo = {"Scourge"},
        AspectThree = {"Armageddon"},
        Generic = {"Special"}
        Melee = {"Generic", "Judicator"},
        Ranged = {"Iron", "Leather"},
        Spell = {"Magic", "Cloth", "Disgraced Gods"},
    },
    Temple Guardian = {
        AspectOne = {"Punisher"},
        AspectTwo = {"Iron Will"},
        AspectThree = {"T-Wolf"},
        Generic = {"Special", "Generic"},
        Melee = {"Iron"},
        Ranged = {"Cloth"},
        Spell = {"Magic", "Leather"},
    },
    Dragon Mage = {
        AspectOne = {"Dragon Magic"},
        AspectTwo = {"Commander"},
        AspectThree = {"Special"},
        Generic = {"Iron", "Generic"},
        Melee = {"Kha-Beleth"},
        Ranged = {"Magic"},
        Spell = {"Cloth", "Leather"},
    },
}

 

The classification is, other than the Aspect and Mutation Set Classification, completely subjective. I just looked at the armor and thought "oh that looks like ranged". Can be modified later by modders.

 

I plan to extract the data from the model name used in itemtype.txt, and then add the flag to each item which uses this specific itemtype. Because flag-conflict might occur, I thought about a usagebits-style flag, but with base 7 and not base 2.

[Lindor 435]

2 hours ago, Lindor said:

I plan to extract the data from the model name used in itemtype.txt

Aaaand Done! Only need to implement the flags system, and all the pieces necessary for the automated bonusgroup generation are there. As far as I can tell, there are 2024 distinct single hero weargroup itemtypes for non-set/unique/legendary armor.

@gogoblender Is it okay if I keep you informed of the progress here? I know other forums where this might be seen as spam.

Edited July 13, 2022 by Lindor

[gogoblender 3,068]

8 minutes ago, Lindor said:

Aaaand Done! Only need to implement the flags system, and all the pieces necessary for the automated bonusgroup generation are there. As far as I can tell, there are 2024 distinct single hero weargroup itemtypes for non-set/unique/legendary armor.

@gogoblender Is it okay if I keep you informed of the progress here? I know other forums where this might be seen as spam.

No worries! You're creating a roadmap of progress.

and around here, stuff lasts a loooooong time

gogo

[Lindor 435]

55 minutes ago, Lindor said:

Only need to implement the flags system

There we go:

Spoiler

local armor = {}
local newItem = {}

newItem = {
    id = 1282,
    name = "hero_chest_strap_fight_magic",
    classificationbits = 6603152
    dmgvariation = 0,
    minconstraints = 5,
    allotment_pmfpi = {1000, 0, 0, 0, 0}, 
    bonusgroup0 = {601, 1000, 1, 9, 0}, 
    bonusgroup1 = {600, 1000, 1, 5, 0}, 
    bonusgroup2 = {599, 1000, 1, 2, 0}, 
    itemtypes = {6781, 8005, 8453, 8582, 9170, 9214, 10056, 10395, 10601, 10607, 12553}, 
    wearergroups = {"WEARGROUP_SERAPHIM", "WEARGROUP_DRYADIN", "WEARGROUP_CENTURIO", "WEARGROUP_TEMPLEGUARDIAN", "WEARGROUP_HIGHELVE", "WEARGROUP_DRAGONMAGE"}
}
do armor[1282] = newItem end

newItem = {
    id = 1283,
    name = "hero_chest_strap_fight_normal",
    classificationbits = 6663453
    dmgvariation = 0,
    minconstraints = 1,
    allotment_pmfpi = {1000, 0, 0, 0, 0}, 
    bonusgroup0 = {601, 900, 1, 9, 0}, 
    bonusgroup1 = {600, 900, 1, 5, 0}, 
    bonusgroup2 = {599, 900, 1, 2, 0}, 
    itemtypes = {3642, 4569, 5667, 6273, 7958, 8452, 8581, 9213, 12289, 12552}, 
    wearergroups = {"WEARGROUP_DRYADIN", "WEARGROUP_CENTURIO", "WEARGROUP_TEMPLEGUARDIAN", "WEARGROUP_HIGHELVE", "WEARGROUP_DRAGONMAGE"}
}
do armor[1283] = newItem end

newItem = {
    id = 1284,
    name = "hero_chest_strap_fight_rare",
    classificationbits = 2343152
    dmgvariation = 0,
    minconstraints = 9,
    allotment_pmfpi = {1000, 0, 0, 0, 0}, 
    bonusgroup0 = {601, 1100, 1, 9, 0}, 
    bonusgroup1 = {600, 1100, 1, 5, 0}, 
    bonusgroup2 = {615, 1100, 1, 2, 0}, 
    bonusgroup3 = {750, 1000, 45, 9, 1}, 
    itemtypes = {8580, 9171, 9172, 10057, 10058, 10396, 10417, 10608, 12782, 12783, 12806, 13464, 13471, 13478}, 
    wearergroups = {"WEARGROUP_SERAPHIM", "WEARGROUP_DRYADIN", "WEARGROUP_CENTURIO", "WEARGROUP_TEMPLEGUARDIAN", "WEARGROUP_HIGHELVE", "WEARGROUP_DRAGONMAGE"}
}
do armor[1284] = newItem end

(.....)

 

The classificationbits are in same order as usagebits. They're NOT converted into decimal, so each digit stands for a hero. This is what the digits mean:

local classificationOrder = {
    AspectOne = 0,
    AspectTwo = 1,
    AspectThree = 2,
    Generic = 3,
    Melee = 4,
    Ranged = 5,
    Spell = 6,
}

Only issue is when one armor has multiple itemtypes with different classifications for the same hero. It's possible to set in balance.lua that each item is created once for each itemtype and disable usagebits though (it's either usagebits or once for each itemtype). I may consider to implement classification directly at the main logic in blueprint.txt. If you choose to use the single itemtype option, then the classification conflict will get solved as well.

[Lindor 435]

The classification conflict happens indeed quite often even within single weargroup items. E.G.:

"hero_wings_technic_normal" has two "leather" itemtypes which I classified as "ranged" and one "special" itemtype which I classified as "generic".

[Lindor 435]

On 7/12/2022 at 10:14 PM, dimitrius154 said:

Actually, there's another step to take beforehand. You'd need to somehow determine the "usage value" of each unique bonus type, so as to apply a correct normalization base. You could, technically, bypass the step by taking a sum of each bonus-of-the-same-type occurence and using a median.

I really shouldn't be awake this late, but you know me Spent whole night to achieve this for items:

Spoiler

local bonusTypeBalance = {}
do bonusTypeBalance["BONUS_STATS_REL"] = {-13.787878787879, 1284.5029239766} end
do bonusTypeBalance["BONUS_SHIELDFACTOR_IGNORE"] = {1349.2530020708, -1662.1041775369} end
do bonusTypeBalance["BONUS_LIFELEECH"] = {29.294269222841, 841.75151784034} end
do bonusTypeBalance["BONUS_LIFEPOINTS"] = {-9.2749234196603, 999.68950153161} end
do bonusTypeBalance["BONUS_ADDCA"] = {57.140117558662, 640.35198958492} end
(.....)

 

The two values are the slope and the y-intercept of the interpolated linear function of the data set of all the (item tier - bonus value) pairs for each bonustype

EDIT: As full list of bonus strengths for item tiers 0-15 it looks like this:

Spoiler

local bonusTypeBalance = {}
do bonusTypeBalance["BONUS_STATS_REL"] = {1284, 1270, 1256, 1243, 1229, 1215, 1201, 1187, 1174, 1160, 1146, 1132, 1119, 1105, 1091, 1077, } end
do bonusTypeBalance["BONUS_CHANCE_KNOCKBACK"] = {307, 410, 513, 616, 719, 823, 926, 1029, 1132, 1235, 1338, 1441, 1544, 1647, 1750, 1853, } end
do bonusTypeBalance["BONUS_DOTDAMPING"] = {678, 719, 760, 801, 842, 883, 924, 965, 1006, 1047, 1088, 1129, 1170, 1211, 1252, 1293, } end
do bonusTypeBalance["BONUS_LIFEPOINTS"] = {999, 990, 981, 971, 962, 953, 944, 934, 925, 916, 906, 897, 888, 879, 869, 860, } end
do bonusTypeBalance["BONUS_LIGHTRANGE"] = {543, 605, 667, 729, 791, 853, 916, 978, 1040, 1102, 1164, 1226, 1288, 1350, 1412, 1474, } end
do bonusTypeBalance["BONUS_REDUCE_BUFFUPKEEPCOST"] = {890, 902, 915, 928, 941, 953, 966, 979, 991, 1004, 1017, 1030, 1042, 1055, 1068, 1080, } end
do bonusTypeBalance["BONUS_RANGEOFSIGHT"] = {0, 61, 236, 411, 587, 762, 937, 1112, 1287, 1462, 1637, 1813, 1988, 2163, 2338, 2513, } end
do bonusTypeBalance["BONUS_EXPERIENCE_REL"] = {1248, 1214, 1179, 1144, 1110, 1075, 1040, 1005, 971, 936, 901, 867, 832, 797, 763, 728, } end
do bonusTypeBalance["BONUS_DEATHBLOW"] = {555, 623, 691, 759, 827, 895, 963, 1031, 1099, 1167, 1235, 1303, 1371, 1439, 1507, 1575, } end
do bonusTypeBalance["BONUS_MENTOR"] = {1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, } end
do bonusTypeBalance["BONUS_DAMPING"] = {0, 69, 225, 381, 537, 693, 849, 1005, 1161, 1317, 1473, 1629, 1785, 1941, 2097, 2253, } end
do bonusTypeBalance["BONUS_STUN"] = {965, 1007, 1048, 1090, 1132, 1173, 1215, 1257, 1298, 1340, 1382, 1423, 1465, 1507, 1548, 1590, } end
do bonusTypeBalance["BONUS_NOEVADE"] = {882, 890, 899, 907, 916, 924, 933, 942, 950, 959, 967, 976, 984, 993, 1002, 1010, } end
do bonusTypeBalance["BONUS_REDUCE_DEBUFFS"] = {1399, 1351, 1304, 1256, 1208, 1161, 1113, 1065, 1018, 970, 922, 875, 827, 779, 732, 684, } end
do bonusTypeBalance["BONUS_ADDCA_HORSE"] = {525, 550, 575, 600, 625, 650, 675, 700, 725, 750, 775, 800, 825, 850, 875, 900, } end
do bonusTypeBalance["BONUS_AREASPLASH"] = {2119, 2071, 2023, 1975, 1927, 1879, 1831, 1784, 1736, 1688, 1640, 1592, 1544, 1496, 1448, 1400, } end
do bonusTypeBalance["BONUS_BLEEDING"] = {1176, 1167, 1159, 1150, 1142, 1133, 1125, 1116, 1108, 1099, 1091, 1083, 1074, 1066, 1057, 1049, } end
do bonusTypeBalance["BONUS_DEBUFF_POTENTIAL"] = {1146, 1133, 1121, 1108, 1096, 1083, 1071, 1058, 1046, 1033, 1021, 1009, 996, 984, 971, 959, } end
do bonusTypeBalance["BONUS_CHANCE_DOUBLEHIT"] = {784, 835, 885, 935, 985, 1035, 1085, 1135, 1185, 1235, 1286, 1336, 1386, 1436, 1486, 1536, } end
do bonusTypeBalance["BONUS_CAN_HEAL"] = {763, 1008, 1253, 1498, 1743, 1988, 2233, 2478, 2723, 2968, 3213, 3458, 3703, 3948, 4193, 4438, } end
do bonusTypeBalance["BONUS_REDUCE_EXTRAEFFECTCHANCE"] = {1083, 1050, 1016, 983, 949, 916, 882, 849, 815, 782, 748, 715, 681, 648, 614, 581, } end
do bonusTypeBalance["BONUS_MAGICFIND"] = {728, 768, 808, 848, 888, 928, 968, 1009, 1049, 1089, 1129, 1169, 1209, 1249, 1289, 1329, } end
do bonusTypeBalance["BONUS_REFLECTION"] = {747, 796, 845, 894, 943, 993, 1042, 1091, 1140, 1189, 1239, 1288, 1337, 1386, 1435, 1485, } end
do bonusTypeBalance["BONUS_ENHANCEPOTION"] = {701, 740, 780, 819, 858, 897, 937, 976, 1015, 1054, 1094, 1133, 1172, 1212, 1251, 1290, } end
do bonusTypeBalance["BONUS_EVADE"] = {926, 940, 954, 968, 982, 996, 1010, 1024, 1038, 1052, 1066, 1080, 1094, 1108, 1122, 1136, } end
do bonusTypeBalance["BONUS_ADDCA"] = {640, 697, 754, 811, 868, 926, 983, 1040, 1097, 1154, 1211, 1268, 1326, 1383, 1440, 1497, } end
do bonusTypeBalance["BONUS_SUREHIT"] = {1128, 1127, 1127, 1126, 1125, 1125, 1124, 1123, 1123, 1122, 1121, 1121, 1120, 1119, 1119, 1118, } end
do bonusTypeBalance["BONUS_REGEN_ASPECT"] = {354, 455, 557, 659, 761, 862, 964, 1066, 1167, 1269, 1371, 1472, 1574, 1676, 1777, 1879, } end
do bonusTypeBalance["BONUS_STATS"] = {984, 996, 1008, 1020, 1032, 1044, 1056, 1068, 1080, 1092, 1104, 1116, 1128, 1140, 1152, 1164, } end
do bonusTypeBalance["BONUS_WEAPONDAMAGE_REL"] = {0, 0, 0, 0, 0, 0, 0, 124, 352, 580, 808, 1035, 1263, 1491, 1719, 1947, } end
do bonusTypeBalance["BONUS_COMBATVALUE_REL"] = {574, 641, 707, 774, 840, 907, 973, 1040, 1106, 1173, 1239, 1306, 1372, 1439, 1505, 1572, } end
do bonusTypeBalance["BONUS_DIRECTDAMAGE"] = {934, 962, 991, 1019, 1047, 1075, 1103, 1131, 1159, 1187, 1216, 1244, 1272, 1300, 1328, 1356, } end
do bonusTypeBalance["BONUS_DISMOUNT"] = {1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, } end
do bonusTypeBalance["BONUS_SHIELD_REL"] = {414, 498, 583, 667, 752, 836, 920, 1005, 1089, 1174, 1258, 1343, 1427, 1511, 1596, 1680, } end
do bonusTypeBalance["BONUS_MORTALSTRIKE"] = {751, 809, 868, 926, 985, 1043, 1101, 1160, 1218, 1277, 1335, 1393, 1452, 1510, 1569, 1627, } end
do bonusTypeBalance["BONUS_SHIELD_RELOAD_REL"] = {518, 574, 631, 687, 744, 800, 857, 913, 970, 1026, 1083, 1139, 1196, 1252, 1309, 1365, } end
do bonusTypeBalance["BONUS_LIFELEECH"] = {841, 871, 900, 929, 958, 988, 1017, 1046, 1076, 1105, 1134, 1163, 1193, 1222, 1251, 1281, } end
do bonusTypeBalance["BONUS_WOUNDEDRAGE"] = {1207, 1185, 1163, 1141, 1120, 1098, 1076, 1054, 1033, 1011, 989, 967, 946, 924, 902, 880, } end
do bonusTypeBalance["BONUS_RIPPER"] = {704, 763, 823, 882, 942, 1002, 1061, 1121, 1180, 1240, 1299, 1359, 1418, 1478, 1538, 1597, } end
do bonusTypeBalance["BONUS_DAMAGE_ANY_REL"] = {105, 240, 375, 510, 645, 780, 915, 1049, 1184, 1319, 1454, 1589, 1724, 1859, 1994, 2128, } end
do bonusTypeBalance["BONUS_REDUCE_ENEMYS_MISSILEREFLECTION"] = {0, 0, 0, 0, 0, 0, 38, 180, 322, 463, 605, 747, 888, 1030, 1172, 1313, } end
do bonusTypeBalance["BONUS_BANISH_UNDEAD_POTENTIAL"] = {1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, 1000, } end
do bonusTypeBalance["BONUS_LIFELEECH_REL"] = {0, 0, 77, 161, 244, 327, 411, 494, 577, 661, 744, 827, 911, 994, 1077, 1161, } end
do bonusTypeBalance["BONUS_CHANCE_BANISH_UNDEAD"] = {856, 936, 1015, 1095, 1175, 1254, 1334, 1414, 1493, 1573, 1653, 1732, 1812, 1892, 1971, 2051, } end
do bonusTypeBalance["BONUS_ENERGYLEECH_WHIT"] = {901, 927, 953, 979, 1005, 1031, 1058, 1084, 1110, 1136, 1162, 1188, 1214, 1240, 1266, 1292, } end
do bonusTypeBalance["BONUS_SURVIVAL_REL"] = {391, 487, 584, 680, 776, 873, 969, 1065, 1162, 1258, 1354, 1451, 1547, 1643, 1740, 1836, } end
do bonusTypeBalance["BONUS_EXTRAEFFECTCHANCE"] = {979, 1002, 1026, 1049, 1073, 1096, 1120, 1143, 1167, 1190, 1214, 1238, 1261, 1285, 1308, 1332, } end
do bonusTypeBalance["BONUS_LIFE_REGENERATION"] = {653, 697, 741, 786, 830, 874, 918, 962, 1007, 1051, 1095, 1139, 1183, 1227, 1272, 1316, } end
do bonusTypeBalance["BONUS_IGNORE_ARMOR"] = {1055, 1066, 1076, 1086, 1097, 1107, 1118, 1128, 1139, 1149, 1160, 1170, 1181, 1191, 1202, 1212, } end
do bonusTypeBalance["BONUS_ADDCA_ASPECT"] = {680, 716, 753, 790, 826, 863, 899, 936, 973, 1009, 1046, 1082, 1119, 1156, 1192, 1229, } end
do bonusTypeBalance["BONUS_CHANCE_FLEE"] = {1121, 1105, 1090, 1075, 1059, 1044, 1029, 1013, 998, 983, 967, 952, 937, 921, 906, 891, } end
do bonusTypeBalance["BONUS_LOWCOST"] = {1075, 1081, 1087, 1093, 1098, 1104, 1110, 1116, 1121, 1127, 1133, 1139, 1144, 1150, 1156, 1162, } end
do bonusTypeBalance["BONUS_NEUTRALIZE_DOT"] = {700, 700, 700, 700, 700, 700, 700, 700, 700, 700, 700, 700, 700, 700, 700, 700, } end
do bonusTypeBalance["BONUS_CHANNELDAMAGE_CONVERSION"] = {725, 767, 809, 850, 892, 934, 976, 1018, 1060, 1102, 1144, 1186, 1227, 1269, 1311, 1353, } end
do bonusTypeBalance["BONUS_SLOT"] = {1085, 1081, 1077, 1074, 1070, 1067, 1063, 1059, 1056, 1052, 1049, 1045, 1041, 1038, 1034, 1031, } end
do bonusTypeBalance["BONUS_DEBUFF_ARMOR_POTENTIAL"] = {1143, 1133, 1123, 1113, 1103, 1093, 1083, 1073, 1063, 1053, 1044, 1034, 1024, 1014, 1004, 994, } end
do bonusTypeBalance["BONUS_SPELL_INTENSITY"] = {1053, 1031, 1008, 986, 963, 941, 919, 896, 874, 851, 829, 806, 784, 762, 739, 717, } end
do bonusTypeBalance["BONUS_CHANCE_SLOWDOWN"] = {616, 675, 733, 791, 850, 908, 966, 1025, 1083, 1141, 1200, 1258, 1316, 1375, 1433, 1491, } end
do bonusTypeBalance["BONUS_REDUCE_ENEMYS_CC_REFLECTION"] = {536, 598, 659, 720, 782, 843, 905, 966, 1027, 1089, 1150, 1211, 1273, 1334, 1395, 1457, } end
do bonusTypeBalance["BONUS_DEEPWOUND"] = {862, 894, 926, 958, 990, 1022, 1054, 1086, 1118, 1150, 1182, 1214, 1246, 1278, 1310, 1342, } end
do bonusTypeBalance["BONUS_SPEED"] = {308, 421, 535, 648, 761, 874, 987, 1100, 1213, 1327, 1440, 1553, 1666, 1779, 1892, 2005, } end
do bonusTypeBalance["BONUS_AREARADIUS"] = {777, 794, 810, 827, 844, 860, 877, 894, 910, 927, 944, 960, 977, 994, 1010, 1027, } end
do bonusTypeBalance["BONUS_WEAPONDAMAGERANGE"] = {1286, 1228, 1169, 1111, 1052, 994, 935, 877, 818, 760, 701, 643, 584, 525, 467, 408, } end
do bonusTypeBalance["BONUS_ARMOR_REL"] = {612, 670, 727, 785, 842, 900, 958, 1015, 1073, 1130, 1188, 1245, 1303, 1360, 1418, 1475, } end
do bonusTypeBalance["BONUS_SHIELDBLOCK"] = {1236, 1203, 1170, 1137, 1105, 1072, 1039, 1006, 974, 941, 908, 875, 843, 810, 777, 744, } end
do bonusTypeBalance["BONUS_PIERCING"] = {854, 883, 912, 941, 970, 1000, 1029, 1058, 1087, 1116, 1145, 1175, 1204, 1233, 1262, 1291, } end
do bonusTypeBalance["BONUS_SPELL_RESISTANCE"] = {640, 696, 753, 809, 866, 923, 979, 1036, 1093, 1149, 1206, 1263, 1319, 1376, 1433, 1489, } end
do bonusTypeBalance["BONUS_SHIELDFACTOR_IGNORE"] = {0, 0, 1036, 2385, 3734, 5084, 6433, 7782, 9131, 10481, 11830, 13179, 14528, 15878, 17227, 18576, } end
do bonusTypeBalance["BONUS_SKILL"] = {984, 992, 1000, 1008, 1016, 1024, 1032, 1040, 1048, 1056, 1064, 1072, 1080, 1089, 1097, 1105, } end
do bonusTypeBalance["BONUS_COMBATVALUE"] = {677, 729, 781, 833, 885, 936, 988, 1040, 1092, 1144, 1195, 1247, 1299, 1351, 1403, 1454, } end
do bonusTypeBalance["BONUS_ARMOR"] = {111, 214, 316, 418, 520, 623, 725, 827, 930, 1032, 1134, 1237, 1339, 1441, 1543, 1646, } end
do bonusTypeBalance["BONUS_CHANCE_BLOCKDAMAGE"] = {1207, 1192, 1177, 1162, 1147, 1132, 1116, 1101, 1086, 1071, 1056, 1041, 1026, 1011, 996, 980, } end
do bonusTypeBalance["BONUS_SHRINKHEAD_ESSENCE"] = {1483, 1433, 1383, 1333, 1283, 1233, 1183, 1133, 1083, 1033, 983, 933, 883, 833, 783, 733, } end
do bonusTypeBalance["BONUS_SHIELDFACTOR"] = {588, 640, 693, 746, 799, 851, 904, 957, 1010, 1062, 1115, 1168, 1221, 1273, 1326, 1379, } end
do bonusTypeBalance["BONUS_CRITICALHIT"] = {694, 747, 801, 855, 908, 962, 1016, 1069, 1123, 1177, 1230, 1284, 1338, 1391, 1445, 1499, } end
do return bonusTypeBalance end

 

As extracted from EE

Edited July 14, 2022 by Lindor

[Lindor 435]

On 7/12/2022 at 10:35 PM, Lindor said:

Hmmm my idea would be:

for each instance of a bonus used, e.g. for each token of each spell in spells.txt, I'm gonna backtrace to the bonus in blueprint.txt, then multiply the bonus strength of the spell token with the highest difficultyvaluerange value of the bonus, divide it by the new highest difficultyvaluerange value, e.g. 100 if I use above normalization, round it to the next integer and then overwrite the old value with the new one.

If I apply this idea, this happens:

Spoiler

(.....)
do bonusTypeBalance["BONUS_ADDCA_HORSE"] = {6, 6, 7, 7, 7, 8, 8, 8, 9, 9, 9, 1, 1, 1, 1, 1, } end
do bonusTypeBalance["BONUS_COMBATVALUE"] = {1, 1, 1, 2, 2, 2, 3, 3, 3, 3, 4, 4, 4, 5, 5, 5, } end
do bonusTypeBalance["BONUS_AREARADIUS"] = {33159504139384, 32141449187817, 31123394236251, 30105339284684, 29087284333117, 28069229381551, 27051174429984, 26033119478417, 25015064526851, 23997009575284, 22978954623717, 21960899672151, 20942844720584, 19924789769017, 18906734817451, 17888679865884, } end
(.....)

 

Ridiculous numbers. Additionally comes the problem that bonusstrength at the blueprint's bonusgroup applies to the whole bonusgroup, making different difficultyvalueranges mandatory.

I will not apply a normalized difficultyvaluerange, instead I will apply a normalized bonusstrength and change the difficultyvaluerange at the bonus for keeping the balance.

 

As a side note: I have no idea why the BONUS_ADDCA_HORSE balance first in- and then decreases. It should be a linear function.

 

EDIT: I know what happened. It was a bug in the code. Nevertheless the problem with the strength applying for all boni in the bonusgroup still holds true, which is why I'll go with the normalized bonusstrength idea.

EDIT2: I just realized that if I did this, I'd sacrifice bonus scaling with item tier. It's the way the system works: Either have scaling with tier or have correct values or have only single bonus bonusgroups. I don't know if and how this is resolvable. Uhmmm... help?

Edited July 14, 2022 by Lindor

[Lindor 435]

6 hours ago, Lindor said:

I just realized that if I did this, I'd sacrifice bonus scaling with item tier. It's the way the system works: Either have scaling with tier or have correct values or have only single bonus bonusgroups. I don't know if and how this is resolvable. Uhmmm... help?

I managed to solve the problem!

The solution is again: linear interpolation!
Here's how it works: I implemented scaling with item tier directly in balance.lua:

Spoiler

    --This is just for scaling with tier. The absolute value doesn't matter. Remember there are 15 item tiers.
    --strength at item tier 1, increase per item tier
    bonusstrength = {1000, 71.4285714286},

These are the values used for ALL bonusgroups, the balance is kept via manipulation of difficultyvaluerange. For each difficulty, the extracted linear bonusstrength function of the item tier is multiplied with the old difficultyvaluerange to get the desired funtion.

Then I modify the difficultyvaluerange so that, when I multiply it with the new linear bonusstrength function of item tier as set in balance.lua and afterwards add the difference between these two function for all item tiers to get the total amount of error, this error equals zero.

 

 

The end result may be a little bit too high/low for low item tiers and too low/high for high item tiers, but the average is the same as the old mod's balance. I'd even argue that it improves the balance as it keeps consistency. And it gives the modder the ability to modify scaling with item tier for all boni with a single number change!

Here's a little snippet of the end result for EE with above settings for bonusstrength:

Spoiler

local bonusTypeBalance = {}
do bonusTypeBalance["BONUS_DEEPWOUND"] = {
    difficultyvaluerange0 = {0, 15, 38},
    difficultyvaluerange1 = {1, 22, 49},
    difficultyvaluerange2 = {2, 29, 59},
    difficultyvaluerange3 = {3, 36, 69},
    difficultyvaluerange4 = {4, 44, 79},
} end
do bonusTypeBalance["BONUS_SUREHIT"] = {
    difficultyvaluerange0 = {0, 18, 36},
    difficultyvaluerange1 = {1, 24, 49},
    difficultyvaluerange2 = {2, 31, 62},
    difficultyvaluerange3 = {3, 37, 74},
    difficultyvaluerange4 = {4, 44, 87},
} end
do bonusTypeBalance["BONUS_LIGHTRANGE"] = {
    difficultyvaluerange0 = {0, 27, 80},
    difficultyvaluerange1 = {1, 38, 111},
    difficultyvaluerange2 = {2, 48, 142},
    difficultyvaluerange3 = {3, 58, 173},
    difficultyvaluerange4 = {4, 69, 204},
} end
(.....)

 

[Flix 5,116]

How will you handle item classifications in typification.txt calling on certain bonusgroups?

[Lindor 435]

1 hour ago, Flix said:

How will you handle item classifications in typification.txt calling on certain bonusgroups?

Wait what do the classifications have tod do with bonusgroups? Do you mean like, if it's CLF_DEFAULT, the correct classification is derived by bonusgroups? If that is so, I wasn't aware of that.

 

I plan a hybrid classification system for weapons: As first instance, it is looked for certain strings present in the item name, like "pole" or "bow" e.g. This half is already completed. If that's inconclusive, it is looked at the Families and Subfamilies of the itemtype. This half is not yet completed.

Theoretically I could advance this system into an automated classifications system. Classifications can always be derived from these three parameters I hope? I have all the possible classifications from the .dll data dump thread.

 

EDIT: Oh I see it's done through typification.txt. With this data, I can correct the classification automatically upon running Enable.exe.

 

EDIT2: Wait you mean the bonusgroup being called by the classification, not the classification being called by the bonusgroup right? Well that's easy to fix then, just change all bonusgroup IDs in typification.txt to 0 upon enabling. When such an amount of confusion happens, it's time to go to sleep. Good night

Edited July 14, 2022 by Lindor

[Lindor 435]

On 7/15/2022 at 12:22 AM, Lindor said:

I plan a hybrid classification system for weapons: As first instance, it is looked for certain strings present in the item name, like "pole" or "bow" e.g. This half is already completed. If that's inconclusive, it is looked at the Families and Subfamilies of the itemtype. This half is not yet completed.

The classification system is up and running, both for weapon and armor. I made it so that it's looked at weargroup and modelname for armor itemtypes to get the standard armor set of the itemtype, and it's looked for both blueprint name and itemtype subfam and only if both classifications match, the itemtype is classified. There is a warning displayed if they don't match.

Btw the Itemtype-Weargroup-Relation works by looking both at itemtype and model weargroup. It's a complicated logic, and I think it's very stable.

 

On 7/13/2022 at 7:56 PM, Lindor said:

I have completed but not finished the Standard Armor Set classification:

  Reveal hidden contents

local classification = {
    Dryad = {
        AspectOne = {"Ivy"},
        AspectTwo = {"Leafs"},
        AspectThree = {"Crystal"},
        Generic = {"Special", "Generic"},
        Melee = {"Iron"},
        Ranged = {"Leather", "Cloth"},
        Spell = {"Magic"},
    },
    Seraphim = {
        AspectOne = {"Angel Dust"},
        AspectTwo = {"Ancient"},
        AspectThree = {"Mystique"},
        Generic = {"Special", "Generic", "Cloth"},
        Melee = {"Iron", "Sophia"},
        Ranged = {"Leather"},
        Spell = {"Magic", "Genesis"},
    },
    Shadow Warrior = {
        AspectOne = {"Enforcer"},
        AspectTwo = {"Exxo"},
        AspectThree = {"Crypt"},
        Generic = {"Special", "Cloth", "Generic"},
        Melee = {"Iron", "Leather"},
        Ranged = {"Redstorm", "Colossus"},
        Spell = {"Magic", "Scourge of Lordaeron", "Hellknight"},
    },
    High Elf = {
        AspectOne = {"Pearl"},
        AspectTwo = {"Diamond"},
        AspectThree = {"Raven"},
        Generic = {"Special", "Cloth", "Generic", "Lara's Glad Rags"},
        Melee = {"Iron", "Children of Asha"},
        Ranged = {"Range Array"},
        Spell = {"Magic", "Leather"},
    },
    Inquisitor = {
        AspectOne = {"Blood Poison"},
        AspectTwo = {"Scourge"},
        AspectThree = {"Armageddon"},
        Generic = {"Special"}
        Melee = {"Generic", "Judicator"},
        Ranged = {"Iron", "Leather"},
        Spell = {"Magic", "Cloth", "Disgraced Gods"},
    },
    Temple Guardian = {
        AspectOne = {"Punisher"},
        AspectTwo = {"Iron Will"},
        AspectThree = {"T-Wolf"},
        Generic = {"Special", "Generic"},
        Melee = {"Iron"},
        Ranged = {"Cloth"},
        Spell = {"Magic", "Leather"},
    },
    Dragon Mage = {
        AspectOne = {"Dragon Magic"},
        AspectTwo = {"Commander"},
        AspectThree = {"Special"},
        Generic = {"Iron", "Generic"},
        Melee = {"Kha-Beleth"},
        Ranged = {"Magic"},
        Spell = {"Cloth", "Leather"},
    },
}

 

The classification is, other than the Aspect and Mutation Set Classification, completely subjective. I just looked at the armor and thought "oh that looks like ranged". Can be modified later by modders.

 

I plan to extract the data from the model name used in itemtype.txt, and then add the flag to each item which uses this specific itemtype. Because flag-conflict might occur, I thought about a usagebits-style flag, but with base 7 and not base 2.

This system is hereby deprecated (the armor set classification is still used though). However I got some useful information out of it: The armors match their purpose for all heroes very rarely. Chaos like this is the most common:

    name = "hero_chest_strap_fight_rare",
    classificationbits = "2343152",

So for an armor set, if it is e.g. Aspect one for Seraphim, one can guarantee that the same armor set has a completely different purpose for another hero.

like e.g. the same item is part of scourge set of inquisitor which is aspect three and part of angeldust set of seraphim which is aspect one. If it's just aspects it would be kinda okay, but there are also items which are spell for one hero and melee for another.

This is very bad because, in case you decide to go with the usagebits-option and not make every item single itemtype, I can't give the armorsets useful boni based on their purpose like that. So if you use usagebits, pretty much every armor with automated bonusgroup generation will either have the ability to spawn every bonus available for the hero on armors, or only general-purpose boni like defensive stuff, depending on your settings in balance.lua.

 

@dimitrius154@FlixIs it possible to get the hero you're currently playing and load this information into blueprint.txt before blueprint.txt is being executed during the server loading stage? If so, I can solve the problem.

Edited July 15, 2022 by Lindor

[Lindor 435]

I think I have to make a pause. The whole day I was feeling out of mental energy, don't know what is with me but at least it's not covid. Just feeling sry because I know Flix wanted to release EE at the end of this month, but I don't know wether I can hold that date for the bonus/item work reshuffle.

However it should be ready at least till the end of august, because I will have very limited time afterwards. It kinda sets a little pressure on me.

[Flix 5,116]

There is absolutely no rush. I'm not sure even to what extent I will bring in your changes, use it as a new base, or just let it be a standalone addition to EE.  The next EE is basically done, consisting mostly of all the bugfixes that have already been seen in D2F and PFP.  Right now I'm just leisurely working on the all the localizations (two restored quests need their text restored for all languages, X2 for Alt. Spells).

Generally I have a feeling of "winding down" for now.  I'm spending most of my free time playing Grim Dawn the past 2 weeks.

[Lindor 435]

I continued working on it a little bit. Not with the same intensity as before, but there's progress being made.

Today I made it so that item modifier which are modified by a relevant skill cannot spawn unmodified on items. Relevant skills are basically all possible modifying skills except alchemist and horseman. I'm debating with myself wether I want to exclude skill_armorer_apprentice (blacksmithing) as well.

Only automated bonusgroup generation is affected by this, items with static boni remain as they are.

I might consider setting up a blacklist for balance.lua so the modder can choose.

[Lindor 435]

I really really strongly dislike the base game's dual wield mechanic. It doesn't make any sense at all that you cannot use a single sword properly without cutting yourself, but as soon as you hold a second sword you transform into Torii Mototada!

If I'm ever getting up to a Dmitriy-level of assembly skills, I'm gonna remove the dual-wield skill entirely together with the need for it to unlock the ability to dual wield, this will be unlocked from the very beginning.

 

Right now it's getting me headache because the boni chosen for a weapon are dependent on the weapon type only. There is no intrinsic dual wield weapon. I cannot unlock boni modified by offhandlore so easily without breaking everything.

Therefore offhand weapon lore will be added to above blacklist by default. If you enable it, those boni which are modified by dual wield will never be able to spawn anywhere, neither modified by dual wield nor unmodified. By disabling, at least the unmodified version can appear.

[gogoblender 3,068]

12 minutes ago, Lindor said:

I really really strongly dislike the base game's dual wield mechanic. It doesn't make any sense at all that you cannot use a single sword properly without cutting yourself, but as soon as you hold a second sword you transform into Torii Mototada!

 

 

 

big lol... had to look it up, but worth it to see who Torii is ... alas, this games coding right?  here's to endless nights but some future coming satisfaction with your +1 increase to all assembly skills 

 

gogo

[Lindor 435]

Some information to this mod outside the blueprint.txt subproject: I have improived the Oren-Nayar lighting model for the fur shader. Most notably, that wierd flickering at the edges where fins generation happens no longer occurs. But there are also some aesthetics/realism/smoothness improvements. I think it looks the most realistic possible.

There are two versions, one with a quadratic (top) and one with a max (bottom) model for combining two lighting values.

Spoiler

Contrary to my expectations, I think the max model looks better.

Does interest exist to update the fur shader pack with this improvement? (@idbeholdME)

Edited July 23, 2022 by Lindor

[idbeholdME 387]

1 hour ago, Lindor said:

Does interest exist to update the fur shader pack with this improvement? (@idbeholdME)

Why not? Seeing how it looks  in motion is the important part 

[Lindor 435]

1 hour ago, idbeholdME said:

Why not? Seeing how it looks  in motion is the important part 

Done, available for download.

I'm interested in your opinion: which of the two looks better you think?

 

BTW I'm not super happy with the specular lighting. It suddenly seems to appear more yellow-ish. Don't know why, in theory should be whiter.

[Lindor 435]

@Flix @dimitrius154

Do you know wether there is a reason that bonusgroup names all have this long string of spaces in the end? Do bonusgroupnames have to have a certain count of characters? Or is it just another random curiosity?

[Flix 5,116]

Not necessary.  Likely some quirk of whatever they used to export the file.

[dimitrius154 612]

3 hours ago, Lindor said:

wether there is a reason that bonusgroup names all have this long string of spaces in the end?

Can't say, but the inloading function is set to ignore the space characters at the end of a string. So, no practical use.

[Lindor 435]

Okay I think the automated bonusgroup generation function is completed. Unfortunately I cannot test it ingame until the whole blueprint.txt logic is set up. The only thing left though is blueprintsets.

We're getting closer to a release. The steps left to do are:

1. completing Enable.exe by writing the blueprintset exporting (should be pretty quick)
2. completing blueprint.txt by completing the non-usagebits single-weargroup option (middle-ish difficulty) and by writing blueprintset importing (also easy)
3. completing Update.exe by applying the (already built) hash/name generation scripts by writing the s2rw commandline scripts, importing and exporting functions (this one is hard)
4. building Disable.exe (easy)
5. Sort every script into correct folder and apply the path generation to all the require() functions (easy, but potentially time consuming)
6. Test ingame and hope I didn't forget anything
7. write the README.txt

Edited July 31, 2022 by Lindor

[Lindor 435]

I can proudly announce that, after some bugfixing during the Disable.exe building (which basically reassembles the original blueprint.txt syntax, therefore being ideal for testing), the automated bonusgroup generation works! Here's a snippet of what it does automatically in the background:

Spoiler

newBonusgroup = {
    id = 1720,
    name = "SB_0spell$spell$spell$$melee$ranged$",
    bonuslist = {1091, 1654, 1633, 1657, 1656, 1599, 164, 1680, 1658, 1609, 1620, 1173, 1017, 983, 1157, 1155, 1153, 501, 1655, 1710},
}
do mgr.createBonusgroup(1720, newBonusgroup) end

newBonusgroup = {
    id = 1721,
    name = "SB_2EA_DM_MENTALISM$generic$melee$$EA_SK_TACTICALCOMBAT$ranged$EA_SE_TECHNICS",
    bonuslist = {1696, 20, 1632, 1635, 1713, 1700, 1689, 1669, 1664, 1616, 1615, 1611, 1610, 1602, 1601, 1701, 1011, 1195, 1600, 21, 1016, 1015, 1014, 1013, 1012, 975, 964, 23, 1693, 24, 1623, 22, 1660},
}
do mgr.createBonusgroup(1721, newBonusgroup) end

newBonusgroup = {
    id = 1722,
    name = "SB_3EA_DM_MENTALISM$generic$melee$$EA_SK_TACTICALCOMBAT$ranged$EA_SE_TECHNICS",
    bonuslist = {766, 76, 759, 844, 813, 1711, 849, 841, 776, 782, 1028, 795, 764, 1667, 817, 456, 781, 976, 846, 1709, 784, 1023, 468, 1716, 448, 765, 444, 430, 443, 754, 471, 1607, 1634, 1706, 412, 753, 855, 458, 1684, 450, 1679, 420, 1699, 799, 1692, 1168, 1665, 80, 1052, 1603, 464, 818, 1719, 1718, 466, 1622, 408, 7, 1612, 1605, 1630, 438, 421, 424, 1566, 1565, 1564, 1563, 1562, 1166, 1019, 437, 73, 172, 1691, 1613, 856, 1604, 814, 1682, 793, 761, 823, 839, 822, 832, 467, 434, 800, 1712, 768, 425, 439, 824, 811, 418, 441, 1170, 810, 442, 1169, 1167, 769, 416, 1121, 1120, 1119, 1118, 1117, 809, 1116, 1115, 1114, 1113, 1112, 1111, 1110, 1109, 1108, 816, 1107, 828, 422, 835, 410, 752, 830, 773, 801, 827, 78, 770, 1054, 1053, 1051, 1050, 1049, 821, 1027, 1025, 1024, 807, 780, 413, 803, 1020, 772, 758, 460, 74, 465, 449, 414, 411, 496, 1022, 1627, 61, 75, 1026, 806, 462, 966, 958, 836, 12, 429, 751, 1708, 1165, 1694, 790, 774, 1029, 858, 857, 854, 853, 852, 851, 850, 848, 847, 845, 843, 842, 840, 838, 837, 407, 417, 834, 463, 833, 831, 829, 77, 826, 825, 820, 819, 815, 812, 808, 805, 804, 802, 798, 797, 796, 792, 791, 789, 788, 787, 786, 785, 783, 39, 779, 778, 777, 775, 451, 409, 771, 767, 762, 760, 757, 756, 755, 40, 415, 435, 446, 431, 426, 1619, 453, 419, 1021, 447, 406, 423, 1707, 98, 38, 455, 503, 79, 433, 473, 470, 469, 461, 459, 454, 452, 445, 440, 41, 436, 432, 428, 427, 1678, 405, 42, 457, 43},
}
do mgr.createBonusgroup(1722, newBonusgroup) end

newBonusgroup = {
    id = 1723,
    name = "SB_1ranged$ranged$spell$$EA_SK_ASTRALPLANE$EA_DR_VOODOO$generic",
    bonuslist = {9, 1618, 146, 1702, 1686, 143, 1704, 1617, 1687, 510, 509, 1705, 145, 1703, 147, 144},
}
do mgr.createBonusgroup(1723, newBonusgroup) end

 

Now if my maths didn't left me, 264 different auto-bonusgroups generated for my tests on EE, additionally to the 1719 single-bonus-bonusgroups. Might be off by one or two, since a couple of IDs are hardcoded and need to remain.

The bonus IDs are all mixed up and won't tell you anything. You basically won't have to worry about bonus IDs ever again, and also not about bonusgroup IDs.

 

Still a bug left though, for some reason the bonusgroup IDs sometimes don't get written out at the blueprint entry which then looks like this:

Spoiler

newBlueprint = {
    id = 1225,
    name = "hero_helmet_full_fight_rare",
    palettebits = "1111111111111111",
    dmgvariation = 0,
    minconstraints = {1, 9, 0},
    lvljump = 1,
    usability = 0,
    allotment_pmfpi = {1000, 0, 0, 0, 0},
    uniquename = "",
    specialuseonly = 0,
    bonusgroup0 = {1926, 1571, 1, 1, 0},
    bonusgroup1 = {1927, 1571, 1, 1, 0},
    bonusgroup2 = {1927, 1571, 1, 1, 0},
    bonusgroup3 = {"", 1000, 1, 1, 0},
    bonusgroup4 = {"", 1000, 1, 1, 0},
    bonusgroup5 = {"", 1000, 1, 1, 0},
    itemtypes = {10036, 10037, 10087, 10088, 10558, 10682, 12841, 13542, 13637},
    wearergroups = 1225,
}
do mgr.createBlueprint(1225, newBlueprint) end

 

Have to figure out what's that all about.

EDIT: Figured it out. It was a series of bugs in the slot creation process. Fixed.
Enough work for today. Lots of progress. Quite an accomplishment.

Edited July 31, 2022 by Lindor

[Lindor 435]

@dimitrius154 For the current implementation of the make-every-item-single-weargroup-option (which is actually more a single-itemtype-option), I have to give the blueprints very big blueprint IDs. Basically I'm concatenating the old ID with the itemtype.
Is there an upper limit for how big blueprint IDs can be?